Re: [HACKERS] multiline CSV fields

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] multiline CSV fields
Date: 2004-12-02 23:58:29
Message-ID: 41AFAC25.3080405@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

I wrote:

>
> If it bothers you that much. I'd make a flag, cleared at the start of
> each COPY, and then where we test for CR or LF in CopyAttributeOutCSV,
> if the flag is not set then set it and issue the warning.

I didn't realise until Bruce told me just now that I was on the hook for
this. I guess i should keep my big mouth shut. (Yeah, that's gonna
happen ...)

Anyway, here's a tiny patch that does what I had in mind.

cheers

andrew

Attachment Content-Type Size
copy.patch text/x-patch 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-12-03 00:07:17 Re: nodeAgg perf tweak
Previous Message Neil Conway 2004-12-02 23:57:20 Re: nodeAgg perf tweak

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-12-03 00:10:51 Re: [HACKERS] multiline CSV fields
Previous Message Zeugswetter Andreas DAZ SD 2004-12-02 23:54:33 Re: [HACKERS] Open Items