Re: Bug in dlgServer

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Alexander Borkowski <alexander(dot)borkowski(at)abri(dot)une(dot)edu(dot)au>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Bug in dlgServer
Date: 2004-10-07 09:39:29
Message-ID: 41650ED1.5040207@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When adding a new server and selecting "require" in the SSL combobox for
> a server that does in fact not support SSL, the following happens after
> submitting the dialog: An error dialog informing about what just went
> wrong comes up and after that the new server dialog comes up again
> (which is all very good), but this time the the options for SSL are
> showing twice. This is because in dlgServer::Go the options are appended
> to cbSSL regardles whether they already are there or not. I was able to
> fix this by wrapping the first few lines (until the #endif) of
> dlgServer::Go in an
>
> if (cbSSL->IsEmpty())
> {
> /* ... */
> }

It's even better not to call Go() from GoNew in that case, to prevent
*any* duplicate initialization (e.g. dlg positioning).

Fixed in cvs, thanks for reporting.

Regards,
Andreas

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message cvs 2004-10-07 11:20:23 CVS Commit by andreas: minor fixes
Previous Message cvs 2004-10-07 09:38:07 CVS Commit by andreas: Fix new server ssl option duplication on connect