Re: move 0 behaviour

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Dave Cramer <dave(at)fastcrypt(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: move 0 behaviour
Date: 2002-10-31 05:16:47
Message-ID: 4102.1036041407@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-jdbc

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The following patch makes FETCH/MOVE 0 do nothing, and FETCH LAST move
> to the end.

Do not hack up PerformPortalFetch; put the special case for INT_MAX in
utility.c's FetchStmt code, instead. As-is, you probably broke other
callers of PerformPortalFetch.

BTW, there's a comment in parsenodes.h that needs to be fixed too:

int howMany; /* amount to fetch ("ALL" --> 0) */

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Brett Schwarz 2002-10-31 05:34:11 Re: PgAccess Visual Query
Previous Message Bruce Momjian 2002-10-31 04:52:28 Re: move 0 behaviour

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2002-10-31 06:09:40 Re: float output precision questions
Previous Message Tom Lane 2002-10-31 05:02:40 Re: 7.2.3 vacuum bug

Browse pgsql-jdbc by date

  From Date Subject
Next Message Dave Bartmess 2002-10-31 06:51:41 Errors compiling jdbc
Previous Message Bruce Momjian 2002-10-31 04:52:28 Re: move 0 behaviour