Re: pg_dump --clean w/ <= 7.2 server

From: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_dump --clean w/ <= 7.2 server
Date: 2004-07-21 01:37:06
Message-ID: 40FDC8C2.4090409@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The last patch of mine you committed just made it all DROP TABLE
public.tab; That at least makes it work.

Chris

Bruce Momjian wrote:

> Where are we on this?
>
> ---------------------------------------------------------------------------
>
> Kris Jurka wrote:
>
>>When running pg_dump --clean against a server that doesn't have schemas
>>the namespace is blank and ends up producing a dump full off things like:
>>
>>DROP TABLE "".tab;
>>
>>The attached patch only includes a schema if one exists. There are
>>numerous comments about the DROPs needing to be fully qualified to avoid
>>conflicting with pg_catalog, but this should be mostly safe because it
>>would require a user defined object to be present in a later server
>>version with the same name, and it is difficult to impossible to drop
>>system objects anyway.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-07-21 01:41:37 Re: [HACKERS] Point in Time Recovery
Previous Message Christopher Kings-Lynne 2004-07-21 01:27:02 Re: Patch for pg_dump: Multiple -t options and new -T option