Bug in CVS pg_dump against 7.0.x

From: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
To: PG Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Bug in CVS pg_dump against 7.0.x
Date: 2004-05-16 14:48:23
Message-ID: 40A77F37.2020405@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi,

I know 7.0.x is pretty old, but I'm wondering if we should fix this to
make it better for people upgrading.

If you create a table like this in 7.0.x:

CREATE TABLE address (
first_name character varying(50) DEFAULT 'asdf' NOT NULL,
last_name character varying(50) NOT NULL,
address character varying(50),
tesing character varying[]
);

The 7.5 pg_dump program will dump it like this:

CREATE TABLE address (
first_name character varying(50) DEFAULT 'asdf' NOT NULL,
last_name character varying(50) NOT NULL,
address character varying(50),
tesing _varchar
);

I have attached a patch that should fix it. I haven't been able to
actually test it since my dev machine and the 7.0 machine I have access
to aren't connected - although it does compile. The fix is based on the
7.0 psql code.

Chris

Attachment Content-Type Size
pg_dump.txt text/plain 1.2 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-16 19:36:50 Re: pg_ctl patch to integrate apache's rotatelogs
Previous Message Nikola Milutinovic 2004-05-16 13:07:51 PgSQL 7.4.2 - NaN on Tru64 UNIX