Re: Function to do runtime relative directory

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Function to do runtime relative directory
Date: 2004-05-04 18:31:27
Message-ID: 4097E17F.40303@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian wrote:

>+ if (toupper(*src) != toupper(*src))
>
>

Shouldn't this be

if (toupper(*src) != toupper(*dst))

?

For completeness, you should probably also check for network drive paths ("\\machine\sharename\foo").

I also think we should just canonicalise everything early, and then never have to worry about / vs \ again.

I must confess I think this scheme is overkill - I can't think of a use case where one would want a relocatable installation which would any pattern other than the one we are thinking of for the windows binary installer. Are we taking flexibility too far?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-04 18:41:32 Re: Function to do runtime relative directory
Previous Message David Fetter 2004-05-04 18:18:48 Resource allocation?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-05-04 18:41:32 Re: Function to do runtime relative directory
Previous Message Dave Page 2004-05-04 18:24:25 Re: man pages on win32

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-04 18:41:32 Re: Function to do runtime relative directory
Previous Message Bruce Momjian 2004-05-04 17:25:36 Function to do runtime relative directory mapping