Re: Shall we just get rid of plpgsql's RENAME?

From: Greg Stark <gsstark(at)mit(dot)edu>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Shall we just get rid of plpgsql's RENAME?
Date: 2009-11-05 11:35:34
Message-ID: 407d949e0911050335sa81635bt8170847f3071c708@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 5, 2009 at 10:18 AM, Stefan Kaltenbrunner
<stefan(at)kaltenbrunner(dot)cc> wrote:
> Tom Lane wrote:
>>
>> According to
>>
>> http://developer.postgresql.org/pgdocs/postgres/plpgsql-declarations.html#PLPGSQL-DECLARATION-RENAMING-VARS
>> the RENAME declaration in plpgsql has been known broken since PG 7.3.
>> Nobody has bothered to fix it.  Shall we just rip it out?
>
> +1 on that - I don't think I have seen it used in any production code I came
> accross in a long time.

I'm fine with just ripping it out. Making it an alias for ALIAS seems
tempting at first but I can't say how often I've found constructs like
that confusing in languages and interfaces because the natural
assumption is that there must be some kind of distinction between the
terms. In the long term it makes things way simpler to understand if
there aren't redundancies like that.

Did we get the keyword from anyplace? Is it an Oracleism or MSSQLism
or anything?

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Roberto Mello 2009-11-05 11:42:01 Re: Shall we just get rid of plpgsql's RENAME?
Previous Message Stefan Kaltenbrunner 2009-11-05 10:18:22 Re: Shall we just get rid of plpgsql's RENAME?