defer statement logging until after parse

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: defer statement logging until after parse
Date: 2004-03-11 16:38:43
Message-ID: 40509613.5010805@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


The attached patch is for review, not application. It defers logging
statements until after they have been parsed. There should be no
observable difference in behaviour if there is a successful parse, and
on error the following traces appear:

line:3 ERROR: syntax error at or near "se3d2" at character 1
line:4 LOG: parse error in statement: se3d2 aaa;

Basically, I want to know that this will not break anything, and if so I
will use it as the basis for a selective statement logging facility,
based on the command tag(s) of the parsed statement(s), and
incorporating Greg Stark's suggesion of a "syntax error" logging level.

cheers

andrew

Attachment Content-Type Size
deferlog.patch text/plain 2.0 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Fabien COELHO 2004-03-11 17:14:21 client side syntax error position (v2)
Previous Message Fabien COELHO 2004-03-11 15:35:38 client side syntax error localisation for psql (v1)