| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Postgresql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: selective statement logging |
| Date: | 2004-03-10 21:51:25 |
| Message-ID: | 404F8DDD.5000602@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
>Andrew Dunstan wrote:
>
>
>>>Yes, look at how the command tag is grabbed for the PS display, and do
>>>the log checks at that point.
>>>
>>>
>>>
>>>
>>>
>>Yes, I thought about that. But it would delay the logging of statements,
>>and I'm not sure that's a good idea. What would happen on parse errors,
>>for example?
>>
>>
>
>Well, if it is parse error, then we can't know what type of command it
>really was. They could type 'SE9ECT 1' or 'SELECT 1 WH8RE x=1' and both
>are not really SELECT commands to me.
>
>
>
If I delay logging until after the parse, these log lines would come out
in reverse order. Not sure if that matters to anyone, but it might annoy
me slightly.
line:3 LOG: statement: se4dt ddd;
line:4 ERROR: syntax error at or near "se4dt" at character 1
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-03-10 22:13:28 | Re: unsafe floats |
| Previous Message | Dennis Bjorklund | 2004-03-10 21:51:06 | unsafe floats |