Re: contrib/xml2 function name change and minor bitrot

From: Neil Conway <neilc(at)samurai(dot)com>
To: John Gray <jgray(at)azuli(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/xml2 function name change and minor bitrot
Date: 2004-03-07 20:45:38
Message-ID: 404B89F2.2010700@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

John Gray wrote:
> I have changed the name of the new parse function to xml_valid and fixed
> a reference to SortMem which meant that the code as supplied would work
> against 7.3 and 7.4 but wouldn't work in CVS. Oops! Patch is attached.

Patch applied.

A few comments on the module:

- can you include some licensing information? "Distributed under the
same terms as PostgreSQL, Copyright ..." should be sufficient unless
you'd prefer another license

- some information on how to configure the location of the libxml2
headers / libs would be good, I think

- the readme for both 'contrib/xml' and 'contrib/xml2' is called
'README.pgxml', yet neither module is actually named 'pgxml'

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Lee Kindness 2004-03-07 21:43:31 ECPG - Remove need for "AT connection" when using threads
Previous Message Neil Conway 2004-03-07 19:35:21 Re: contrib/xml2 function name change and minor bitrot