| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Streaming Replication on win32 |
| Date: | 2010-02-16 02:02:20 |
| Message-ID: | 3f0b79eb1002151802t34098ed9o609809fd84d3f9a3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 16, 2010 at 1:33 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> 2010/2/15 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> I changed your patch to this, because I find it a lot simpler. The
>>> change is in the checking in pgwin32_recv - there is no need to ever
>>> call waitforsinglesocket, we can just exit out early.
Thanks a lot, Magnus!
>>> Do you see any issue with that?
>>
>> This definitely looks cleaner, but is there a reason not to use bool
>> instead of int here?
>
> No.
Can include/port/win32.h refer to bool type?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-02-16 02:48:36 | Re: Explain buffers display units. |
| Previous Message | Fujii Masao | 2010-02-16 00:58:05 | Re: TCP keepalive support for libpq |