| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Hot Standby, release candidate? |
| Date: | 2009-12-14 11:15:47 |
| Message-ID: | 3f0b79eb0912140315o789de41ehe22ba0e359651307@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 14, 2009 at 8:07 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> * Please remove any spurious whitespace. "git diff --color" makes them
>> stand out like a sore thumb, in red. (pgindent will fix them but always
>> better to fix them before committing, IMO).
>
> What is your definition of spurious whitespace? I removed all
> additions/deletions of individual lines. git diff colours many things
> red, and it seems like a waste of time to spend hours fiddling with
> spaces manually if there is a utility that does this anyway.
I guess it's a trailing whitespace. How about using "git diff --check"
instead of "--color"?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-12-14 11:18:39 | Re: Row-Level Security |
| Previous Message | Simon Riggs | 2009-12-14 11:11:46 | Re: Hot Standby, release candidate? |