Re: pg_dump doesn't dump binary compatible casts

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump binary compatible casts
Date: 2003-09-27 15:46:06
Message-ID: 3F75B0BE.40700@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
>> That eliminated, a cast should be dumped if one or more of the three
>> objects (source, target and function) are not builtin AND all the
>> non-builtin objects belong to namespaces included in the dump.
>
> Where "builtin" is defined as "belongs to pg_catalog schema", you mean?
> I think that works for me ...

Okay,

I have more precisely defined "builtin" as "belongs to a schema who's
name starts with pg_", as that is how we distinguish what namespaces get
dumped in the first place.

The patch is applied to 7.4 according to being a bug. The same patch
would cleanly apply to 7.3.4 as well, so my question is do we want to
backpatch?

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

Attachment Content-Type Size
pg_dump_cast.diff text/plain 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rémi Zara 2003-09-27 16:11:42 Re: Postgresql 7.3.4 compile failes on NetBSD 1.6 mac68k
Previous Message Bruce Momjian 2003-09-27 15:40:38 Re: FreeBSD Thread-safe functions ...