Re: GUC patch for Win32

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: GUC patch for Win32
Date: 2003-05-08 15:40:19
Message-ID: 3EBA7A63.E8DC324@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
>
> I said:
> > That way the file never changes after postmaster start and there can
> > be no race condition. Children will instead have to read
> > postgresql.conf for themselves during their launch (after they read the
> > nondefault_variables file), but that's an easy one-line addition.
>
> On second thought, that just moves the race condition upstream (to the
> person editing postgresql.conf) ... so never mind that idea. We don't
> want any part of Postgres reading postgresql.conf except shortly after
> someone has SIGHUP'd the postmaster.

I didn't actually look at that part of the code yet ... why would any
backend read postgresql.conf? I thought only the postmaster does that
and that he SIGHUP's all backends after writing the new file. That way
there is not race condition other that hupping the PM while w'ing the
file.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-05-08 15:49:41 Re: GUC patch for Win32
Previous Message Tom Lane 2003-05-08 13:59:50 Re: GUC patch for Win32