While implementing a function for making view definitions look prettier
in pgadmin3, I had a look at ruleutils.c to examine why there are tons
of parentheses coming out of pg_get_viewdef. I believe that some are
really not needed.
These are:
- get_rule_expr, for CASES T_RelabelType and T_CoerceToDomain. The cast
is always bound to the near left variable, so it can be left out.
- get_from_clauses for ON. Operators will deliver what is needed.
for get_rule_expr and get_from_clauses(JOIN part), parentheses could be
omitted if the top-level expression is evaluated.
Do you agree?
Regards,
Andreas