Re: contrib/cube & contrib/seg regression fixes

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/cube & contrib/seg regression fixes
Date: 2002-09-19 05:26:10
Message-ID: 3D895FF2.8050206@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>>FWIW, both seg and cube have "#define YYERROR_VERBOSE", which seems to
>>add the expected/unexpected text. It might solve the issue to remove
>>the define and accept slightly less verbose output.
>
> That sounds like a plan to me; if the verbose output varies from one
> bison version to another, then we should turn it off in the standard
> build. (Anyone who really wants it can turn it on again.)
>
> Any objections out there?
>

I haven't seen any objections, so here is a patch. It removes "#define
YYERROR_VERBOSE" from contrib/cube and contrib/seg, and adjusts the expected
output accordingly. Hopefully this will consistently pass across multiple
bison versions.

If no objections materialize, please apply.

Thanks,

Joe

Attachment Content-Type Size
contrib-cube-seg-regr-fix.patch text/plain 7.8 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Karel Zak 2002-09-19 08:50:38 Re: to_char() code cleanup
Previous Message Bruce Momjian 2002-09-18 23:56:26 Re: make_greater_string busted