| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Thomas Lockhart <lockhart(at)fourpalms(dot)org> |
| Subject: | Re: unknownin/out patch (was [HACKERS] PQescapeBytea is |
| Date: | 2002-04-08 02:43:20 |
| Message-ID: | 3CB103C8.1000909@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Joe Conway wrote:
> Here's a patch to add unknownin/unknownout support. I also poked around
> looking for places that assume UNKNOWN == TEXT. One of those was the
> "SET" type in pg_type.h, which was using textin/textout. This one I took
> care of in this patch. The other suspicious place was in
> string_to_dataum (which is defined in both selfuncs.c and indxpath.c). I
> wasn't too sure about those, so I left them be.
>
I found three other suspicious spots in the source, where UNKNOWN ==
TEXT is assumed. The first looks like it needs to be changed for sure,
the other two I'm less sure about. Feedback would be most appreciated
(on this and the patch itself).
(line numbers based on CVS from earlier today)
parse_node.c
line 428
parse_coerce.c
line 85
parse_coerce.c
line 403
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-04-08 03:17:45 | Re: timeout implementation issues |
| Previous Message | Christopher Kings-Lynne | 2002-04-08 02:17:59 | Re: RFC: Restructuring pg_aggregate |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2002-04-08 03:52:02 | Re: PQescapeBytea is not multibyte aware |
| Previous Message | Joe Conway | 2002-04-07 23:18:57 | unknownin/out patch (was [HACKERS] PQescapeBytea is not multibyte aware) |