Re: Small fix for _equalValue()

From: Thomas Lockhart <thomas(at)fourpalms(dot)org>
To: Fernando Nasser <fnasser(at)redhat(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small fix for _equalValue()
Date: 2002-03-09 17:47:19
Message-ID: 3C8A4AA7.64CA36C4@fourpalms.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > Possibly a more interesting question, though, is *why* equalValue is
> > seeing Values with null pointer parts. I cannot think of any good
> > reason to consider that a legal data structure. Do you know where this
> > construct is coming from? I'd be inclined to consider the source at
> > fault, not equalValue.
> Someone is using NULL strings in gram.y, like in:
...
> there are several instances of it, all related to variable set.
> Well, NULL is a valid value for a (char *) so this seems legal
> enough to me.

OK, I've committed a patch to the stable and development trees which
adds a guard check in three places in gram.y, matching the guards
already in place for other cass in the same area.

Fernando, can you please check this (preferably without your patches to
guard the output functions, since those mask the upstream problem)?

Or, can you give me the complete test case you are using to demonstrate
the problem to make sure I'm testing the thing you are seeing?

While I'm looking at it, the "SET key=val" area is somewhat "kludge on
kludge" to enable lists of values, at least partly because it was at the
end of the development cycle and I didn't want to ripple breakage into
parts of the code I wasn't trying to touch. I'll go through and try to
rationalize it sometime soon (actually, I've already started but haven't
finished).

- Thomas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Olivier PRENANT 2002-03-09 18:04:18 need help
Previous Message Tom Lane 2002-03-09 15:26:31 Re: TODO question

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-03-09 18:33:27 Re: Small fix for _equalValue()
Previous Message Rod Taylor 2002-03-09 03:18:29 Re: Domain Support -- another round