From: | Fernando Nasser <fnasser(at)redhat(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Allows for commands to be processed iteractively |
Date: | 2002-03-01 16:02:34 |
Message-ID: | 3C7FA61A.643B1203@redhat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
>
> Fernando Nasser <fnasser(at)redhat(dot)com> writes:
> > Allows for some commands to be processed iteractively.
>
> This patch seems to be missing quite a lot, like the node struct
> definition and backend/nodes/*.c support for CreateSchemaStmt.
> Perhaps your intention was not to introduce that yet, but in that
> case I'd suggest not adding any sign of it in this patch.
>
> More to the point, though, what is the reason for restructuring
> pg_exec_query_string this way? The patch doesn't make any sense
> to me as presented. I should think that any effort needed for
> CREATE SCHEMA would be over in parser/analyze.c; restructuring
> pg_exec_query_string isn't going to help.
>
Please see the follow-up patch and things get more clear.
I broke the patch in two to make it easier to access the impact
of each part (I can glue both together again, if desired).
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser(at)redhat(dot)com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-03-01 16:26:39 | Re: Adds the parsing of a CREATE SCHEMA statement |
Previous Message | Tom Lane | 2002-03-01 16:00:30 | Re: Allows for commands to be processed iteractively |