Re: Fix for fetchone() and fetchmany() in Python interface

From: Neil Padgett <npadgett(at)redhat(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Fernando Nasser <fnasser(at)cygnus(dot)com>, gerhard(at)bigfoot(dot)de, pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for fetchone() and fetchmany() in Python interface
Date: 2001-08-15 21:30:17
Message-ID: 3B7AE9E9.AC321A32@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
>
> > Gerhard H?ring wrote:
> > >
> > > This patch fixes the well-known but unfixed bug that fetchone() always returns
> > > the first result in the DB-API compliant wrapper. It turned out that the bug
> > > was way down in the C code.
> > >
> > > Gerhard
> >
> > This is great. It solves a problem we were having.
> >
> > Bruce: this should go into 7.1.3 (if possible). It applies cleanly and,
> > without it, we basically can't use Python (cursors don't work, basically).
>
> We only put major lowrisk fixes in 7.1.X releases, and this one is too
> minor for the risk. Sorry.
>

I think this patch is important enough -- it fixes an annoying broken
call, with a two line patch that is quite localized. So, the risk level
seems quite low. AFAICT, the worst thing this patch could do is keep
fetch as broken, though perhaps in a different way. But, even then, I'm
fairly confident that the patch is good, or at least better than what
we've got, since we've already tried it out here, and found it to
apparently fix the issue.

Neil

--
Neil Padgett
Red Hat Canada Ltd. E-Mail: npadgett(at)redhat(dot)com
2323 Yonge Street, Suite #300,
Toronto, ON M4P 2C9

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-15 21:32:05 Re: Fix for fetchone() and fetchmany() in Python interface
Previous Message Peter Eisentraut 2001-08-15 21:29:03 Re: Re: Proposal for encrypting pg_shadow passwords