Re: ALTER TABLE DROP COLUMN

From: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: ALTER TABLE DROP COLUMN
Date: 2000-10-05 23:12:14
Message-ID: 39DD0ACE.32E49372@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> > Seems some people expect the implementation in 7.1.
> > (recent [GENERAL} drop column?)
> > I could commit my local branch if people don't mind
> > backward incompatibility.
>
> I've lost track --- is this different from the _DROP_COLUMN_HACK__
> code that's already in CVS? I really really didn't like that
> implementation :-(, but I forget what other methods were being
> discussed.
>

My current local trial implementation follows your idea(logical/
physical attribute numbers).

> > P.S. I've noticed that get_rte_attribute_name() seems to
> > break my implementation. I'm not sure if I could solve it.
>
> That would be a problem --- rule dumping depends on that code to
> produce correct aliases, so making it work is not optional.
>

Your change has no problem if logical==physical attribute
numbers.

Regards.

Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-10-06 00:46:19 Re: query returns incorrect results.
Previous Message Brian Hirt 2000-10-05 21:58:56 query returns incorrect results.