Re: LIKE gripes

From: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: LIKE gripes
Date: 2000-08-07 03:34:24
Message-ID: 398E2E40.7BD1F9A4@alumni.caltech.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > OK, will look at it. The first ones I see here; the second I'm not sure
> > I do. Will see what other files have for #include's.
> I think <ctype.h> is what's needed here.

OK, I've updated builtins.h and like.c to eliminate compiler warnings,
and updates the strings.out regression test result file. I've also
updated the like support code to

1) eliminate a gratuitous case statement (actually, two) in favor of an
if/elseif/else construct.

2) eliminate the extraneous backslash quoting code for like() functions
only. As I mentioned in the cvs note, this behavior can be put back in
if we really want it by replacing a NULL with a "\" in two function
calls.

- Thomas

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2000-08-07 05:51:47 Re: Re: scp daemon working?
Previous Message Tom Lane 2000-08-07 01:12:22 Re: LIKE gripes