| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Stark <gsstark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Please test peer (socket ident) auth on *BSD |
| Date: | 2011-06-02 16:44:02 |
| Message-ID: | 3834.1307033042@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Marko Kreen <markokr(at)gmail(dot)com> writes:
> On Thu, Jun 2, 2011 at 7:20 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Then maybe we need to use "#ifndef WIN32" in those places. That's what we do
>> for similar cases.
> No, that would be a bad idea - uglifies code for no good reason.
> The function is referenced undef IS_AF_UNIX() check, so it would
> not be run anyway. Even if it would run somehow, there is only
> 2 lines to return ENOSYS.
Yeah, but not compiling thirty lines in fe-connect.c is worthwhile.
The auth_peer code in the backend is #ifdef HAVE_UNIX_SOCKETS, and
I see no reason why this chunk in libpq shouldn't be as well.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Kreen | 2011-06-02 16:45:04 | Re: Please test peer (socket ident) auth on *BSD |
| Previous Message | Tom Lane | 2011-06-02 16:39:54 | Re: vacuum and row type |