Re: [HACKERS] Re: [PATCHES] COMMENT ON patch

Mike Mascari wrote:
>
> --- Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> ...
> > Just to confirm a few things here: Are you keying rule comments on
> > pg_rewrite.oid? Are operator comments keyed on the oid of the underlying
> > function? (Perhaps that could even be changed so you can put a comment
> > on
> > the operator and a note like "implementation of %^*& operator" on the
> > function. Just a thought.)
> >
> > Now we just have to stick a whole bunch of comments on all system stuff.
> > Where would be a good place to do this? Where are all the comments on
> > the
> > built-in operators generated?
>
> ...
> Hmm, this is where I'm getting the oid's:
>
> DATABASE -- pg_database
> INDEX -- pg_class
> RULE -- pg_rewrite
> SEQUENCE -- pg_class
> TABLE -- pg_class
> TYPE -- pg_type
> VIEW -- pg_class
> COLUMN -- pg_attribute
> AGGREGATE -- pg_aggregate
> FUNCTION -- pg_proc
> OPERATOR -- pg_operator
> TRIGGER -- pg_trigger
>
> So in the example you gave above, you could put a comment
> on each of the two functions which compose the operator
> and a command on the operator itself.
>
> I still need to write the SGML and change pg_dump to
> generate COMMENT ON statements, and also regression tests,
> but the functionality should be complete. Just glancing
> over the Win32 ODBC driver, it appears that SQLTables() and
> SQLColumns() is not currently fetching the associated
> description from pg_description for the REMARKS parameter
> to the call. Perhaps this could be changed?
>
> Hope that helps,
>
> Mike Mascari (looking forward to the new psql...)
> (mascarim(at)yahoo(dot)com)
>
> =====
>
> __________________________________________________
> Do You Yahoo!?
> Bid and sell for free at http://auctions.yahoo.com

It wouldn't be hard to add the pg_description to the remarks.
Does this field exist for all previous postgres releases (specifically,
6.2,6.3, and 6.4) ??

Byron