Re: How to submit a patch

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: How to submit a patch
Date: 2008-04-16 19:47:44
Message-ID: 37ed240d0804161247v5d5bc605l8c080afb3ddcff98@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, Apr 17, 2008 at 5:17 AM, Bruce Momjian
wrote:
> Andrew Dunstan wrote:
> > Bruce Momjian wrote:
> > >
> > > This is one of the reasons I didn't want to add wiki maintenance to my
> > > already full workload. Instead I am having to field complaints.
> >
> > I didn't mean to complain about anything. Personally, I'm in favor of
> > reducing your workload.
>
> OK. FYI, what would be really nice would be for someone to review and
> apply the patch or give the author feedback so we could avoid adding it
> to the wiki at all.

Bruce,

Yes, that would be nice! But not likely in practice, unless your
patch happens to immediately catch the interest of a suitably
qualified person with commit privileges.

However, I don't know of any way the maintenance of the wiki is an
addition to your workload. I feel that the onus of adding the patch
to the wiki should be on the submitter, and we've already had some
success getting submitters to add their own patches. And Alvaro has
already offered to pick up the slack in cases where the submitter
fails to add their patch to the queue.

Every patch that somebody else adds to the wiki is another patch you
don't have to add to your queue, so how can this be anything but a
plus for you?

Cheers,
BJ

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFIBlfb5YBsbHkuyV0RAs6tAKDNR3CbqFC4YwROaoiwNMXSWKXWTgCbBaz1
pO90zcotv+/UMJrotfDTg/M=
=IY5R
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-04-16 19:59:01 Re: DROP DATABASE vs patch to not remove files right away
Previous Message Bruce Momjian 2008-04-16 19:17:22 Re: How to submit a patch

Browse pgsql-www by date

  From Date Subject
Next Message Merlin Moncure 2008-04-16 20:03:03 Re: How to submit a patch
Previous Message Bruce Momjian 2008-04-16 19:17:22 Re: How to submit a patch