Re: to_char incompatibility

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Roberts, Jon" <Jon(dot)Roberts(at)asurion(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: to_char incompatibility
Date: 2008-01-17 09:16:24
Message-ID: 37ed240d0801170116w3f91ec27se1132a0a7f9d9193@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jan 17, 2008 8:22 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Andrew Dunstan wrote:
> > Tom Lane wrote:
> > > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > >
> > >> A further example shows that to_date seems to have little error checking
> > >> altogether:

> > TODO list item?
>
> We have something on hold for 8.4:
>
> http://momjian.us/mhonarc/patches_hold/msg00319.html

Yeah, the date/time formatting code is rife with these kinds of
issues. I've been poking around in there for a while. The patch
Bruce mentioned was my attempt to refactor some of the code, making it
easier to work with.

Depending on how the review of that patch goes, I'll then be putting
in some effort to make to_date actually check that the formatting
pattern is legal (see thread at
http://archives.postgresql.org/pgsql-hackers/2007-07/msg00513.php).

So, I am keen to improve this area, but it's slow going. I don't have
a great deal of experience with Postgres, C isn't my native tongue and
the review cycle is ponderous.

Cheers,
BJ

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian G. Pflug 2008-01-17 10:56:48 Re: Transaction Snapshot Cloning
Previous Message Achilleas Mantzios 2008-01-17 08:21:33 Re: postgresql in FreeBSD jails: proposal