Re: A small rant about coding style for backend functions

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Gregory Stark" <stark(at)enterprisedb(dot)com>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Subject: Re: A small rant about coding style for backend functions
Date: 2007-11-08 08:36:40
Message-ID: 37ed240d0711080036i401e0820lf7c59e18d610c60f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Nov 8, 2007 2:49 AM, Gregory Stark <stark(at)enterprisedb(dot)com> wrote:
>
> None of these points in here seem at all analogous to the important kind of
> style details like what Tom was pointing out about using GETARG_* at the top
> of your function to make the argument types clear.
>

I would love to see a Postgres style guide which includes both: things
that are peculiar to the Postgres codebase like GETARG, and an actual
standard on how to use whitespace, formatting and naming consistently.

If Postgres did have something akin to the Python C style guide, that
would be excellent. But all we've got is a standard tabstop of four
spaces and the five words "Our standard format BSD style". Don't you
think that comes across as pretty weak for a project of this size and
significance?

Cheers,
BJ

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2007-11-08 09:21:50 Re: Visibility map thoughts
Previous Message Josh Berkus 2007-11-08 06:37:19 Re: Bug: --with-libxml does not take a location