Re: Cost of AtEOXact_Buffers in --enable-cassert

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Cost of AtEOXact_Buffers in --enable-cassert
Date: 2010-08-15 19:41:09
Message-ID: 3751.1281901269@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On Friday 06 August 2010 20:23:15 Tom Lane wrote:
>> I'd be willing to consider a "half assert" mode that turns off some of
>> the most expensive checks, but AtEOXact_Buffers is hardly the only thing
>> that ought to be in that list. The CLOBBER_FREED_MEMORY and memory
>> context checking stuff is pretty durn expensive too.

> I personally have seen that catching way more bugs than the AtEOXact_Buffers
> check, but that might be because I have found mostly bugs in random c
> functions, not in pg stuff ;-)

Nobody else seems to have commented, but maybe what this suggests is
we need to be able to individually disable a few of the most expensive
checks. I'm not sure what a reasonable API is for that ... not sure
that I like the thought of a GUC for each one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2010-08-15 19:48:29 Re: Cost of AtEOXact_Buffers in --enable-cassert
Previous Message Tom Lane 2010-08-15 19:22:06 Re: LockDatabaseObject vs. LockSharedObject