Re: BUG: pg_stat_statements query normalization issues with combined queries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG: pg_stat_statements query normalization issues with combined queries
Date: 2017-01-14 21:18:49
Message-ID: 3732.1484428729@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> It ends up being about 30 fewer lines of code overall, despite there
>> being four places that have to make ad-hoc RawStmt nodes. On the whole
>> I feel like this is cleaner,

> I agree: Better typing, more homogeneous code (PlannedStmt for all),
> less ad-hoc checks to work around utility statements...

OK, pushed like that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-01-15 04:11:38 Re: Parallel Index Scans
Previous Message Peter Geoghegan 2017-01-14 20:26:39 Re: Packages: Again