Re: Block-level CRC checks

From: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
To: "Josh Berkus" <josh(at)agliodbs(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Greg Stark" <greg(dot)stark(at)enterprisedb(dot)com>, "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Block-level CRC checks
Date: 2008-12-15 04:03:33
Message-ID: 36e682920812142003x4dae3e7ev7ed7af93742d9aec@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 14, 2008 at 4:51 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>>> v11 doesn't apply to cvs head anymore
>>
>> I'm not currently working on this patch, sorry.
>>
>
> Should we pull it from 8.4, then?

Here's an updated patch against head.

NOTE, it appears that this (and the previous) patch PANIC with
"concurrent transaction log activity while database system is shutting
down" on shutdown if checksumming is enabled. This appears to be due
to FlushBuffer (lines 1821-1828) during the checkpoint-at-shutdown.
Other than that, I haven't looked into what needs to be done to fix
it.

Similarly, I ran a pgbench, performed a manual checkpoint, and
corrupted the tellers table myself using hexedit but the system didn't
pick up the corruption at all :(

Alvaro, have you given up on the patch or are you just busy on
something else at the moment?

--
Jonah H. Harris, Senior DBA
myYearbook.com

Attachment Content-Type Size
blkcrc-12.patch application/octet-stream 24.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2008-12-15 06:39:21 Re: pre-MED
Previous Message Robert Haas 2008-12-15 02:41:38 Re: Sync Rep: First Thoughts on Code