| From: | "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] EnableDisableTrigger Cleanup & Questions |
| Date: | 2008-11-06 14:49:13 |
| Message-ID: | 36e682920811060649k1f029700gca1026af46486ed8@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 6, 2008 at 9:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It would have been useful to make this criticism before 8.3 was
> released. I don't think it's reasonable to change it now.
Well, I didn't have time to review code back in the 8.3 days, and ugly
is ugly regardless of when it was originally committted. I'm not
saying it needs to be an 8.4 fix, just that as a whole, several of the
components of that patch (including rewrite) seem to be a little
hackish and that they could be cleaned up in 8.5. I would imagine
someone will be working on trigger-related code in 8.5, and just
thought it would be nice to clean it up if one had the time to do so.
--
Jonah H. Harris, Senior DBA
myYearbook.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-11-06 15:07:30 | Re: Timing problem in DROP TABLESPACE? |
| Previous Message | Robert Haas | 2008-11-06 14:39:27 | Re: [WIP] In-place upgrade |