Re: Miscellaneous changes to plperl [PATCH]

From: Alex Hunsaker <badalex(at)gmail(dot)com>
To: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
Cc: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Miscellaneous changes to plperl [PATCH]
Date: 2010-01-23 19:20:23
Message-ID: 34d269d41001231120x267ecad9h9d2620e1517c7904@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 23, 2010 at 11:30, David E. Wheeler <david(at)kineticode(dot)com> wrote:
> On Jan 22, 2010, at 7:59 PM, Alex Hunsaker wrote:
>
>>    $name =~ s/::|'/_/g; # avoid package delimiters
>> +   $name =~ s/'/\'/g;
>
> Looks to me like ' is already handled in the line above the one you added, no?

Well no, i suppose we could fix that via:
$name =~ s/[:|']/_/g;

Im betting that was the intent.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2010-01-23 19:25:21 Re: commit fests
Previous Message Boszormenyi Zoltan 2010-01-23 19:16:38 Re: 8.5 vs. 9.0, Postgres vs. PostgreSQL