Re: [HACKERS] Running pgindent

From: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Running pgindent
Date: 1998-02-19 15:32:39
Message-ID: 34EC5097.156A687D@alumni.caltech.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:

> I want to run pgindent before the final release. Who has outstanding
> patches they are sitting on that would be affected by this? Only places
> where we have added non-conforming code would be affected.

Ack! Can you make at least three changes to pgindent before doing this?

1) for functions which look like
datetime *
abstime_datetime(int4 x)
{
...
do not put a tab (or extra spaces) between "datetime" and "*".

For the end of functions which look like
...
} /* abstime_datetime() */

do not put any tabs (or just one) between the "{" and the comment.

Also, some comments get wrapped to the next line, making some ugly sources;
perhaps pgindent should not touch comment lines at all? Or at least keep
things on the same line, messing with the tabbing only??

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message al dev 1998-02-19 15:46:25 unsubscribe
Previous Message Bruce Momjian 1998-02-19 15:15:35 Re: AW: [HACKERS] Solution to the pg_user passwd problem !?? (c)