Potential RC1-stoppers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Potential RC1-stoppers
Date: 2001-03-22 16:03:51
Message-ID: 3437.985277031@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm currently concerned about these recent reports:

* Joel Burton's report of disappearing files, 3/20. This is real scary,
but no one else has reported anything like it.

* Tatsuo's weird failure in XLogFileInit ("ZeroFill: no such file or
directory"). I'm hoping this can be explained away, but probably we
ought to alter the code so that we can detect the case where no errno
is set by write() and avoid printing a bogus message.

Do people feel comfortable putting out RC1 when we don't know the
reasons for these reports?

Another thing I'd like to fix before RC1 is Adriaan's complaint about
mishandling of int8-sized numeric constants on Alpha. Seems to me that
we want Alpha to behave like other platforms, ie T_Integer parse nodes
should only be generated for values that fit in int4. Otherwise Alpha
will have different type resolution behavior for expressions that
contain such constants, and that's going to be real confusing. I'm
thinking about making scan.l do

long x;

errno = 0;
x = strtol((char *)yytext, &endptr, 10);
if (*endptr != '\0' || errno == ERANGE
#ifdef HAVE_LONG_INT_64
/* if long is wider than 32 bits, check for overflow */
|| x != (long) ((int32) x)
#endif
)
{
/* integer too large, treat it as a float */

Objections?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Larry Rosenman 2001-03-22 16:08:05 Re: odbc/UnixWare 7.1.1: No Go.
Previous Message The Hermit Hacker 2001-03-22 15:56:34 Re: Re: Call for platforms