| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ... |
| Date: | 2002-08-17 15:14:57 |
| Message-ID: | 3293.1029597297@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
momjian(at)postgresql(dot)org (Bruce Momjian - CVS) writes:
> Everytime if I do PQconsumeInput (when the backend channel gets
> readable) I check for the return value. (0 == error) and generate a
> notification manually, e.g. fixed string connection_closed) and pass it to the
> TCL event queue.
Was that patch reviewed by anyone? I don't think I've even seen it
successfully posted --- the submitter seemed to be having trouble
attaching it.
From the description, I don't think I trust it much. Event queue stuff
is subtle ...
> The only other thing I had to do is to comment out removing
> all pending events in PgStopNotifyEventSource whenever the connection was
> unexpectedly closed (so the manually generated event will not be deleted).
... and this is *very* likely to break things.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-08-17 15:23:55 | Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ... |
| Previous Message | Bruce Momjian | 2002-08-17 15:13:56 | Re: [COMMITTERS] pgsql-server/src backend/tcop/postgres.cbacke |