Re: Patch Submission Guidelines

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <simon(at)2ndquadrant(dot)com>, <kleptog(at)svana(dot)org>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch Submission Guidelines
Date: 2006-02-15 00:04:35
Message-ID: 3198.24.211.165.134.1139961875.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane said:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
>> How much time would you need? I think having every patch built before
>> anyone even looks at the code would sort out most of the issues I
>> mentioned.
>
> If I ran a buildfarm machine, I'd turn it off immediately if anyone
> proposed setting up a system that would cause it to run code no one had
> vetted... so I don't think the above will fly. It might or might not
> be worth doing something with patches that have passed some kind of
> initial review but aren't yet applied.
>

Yes, I agree. Whast I had in mind was adding some sort of experimental
branch to CVS.

> IMHO the thing we are really seriously short of is patch reviewers.
> Neil and Bruce and I seem to be the only ones doing that much at all,
> and the main burden is falling on Bruce. More eyeballs would help much
> more than throwing machines at the problem.
>

Unfortunately, demands from my real job increased enormously right at the
time I was given commit privileges. I don't know when that will change.

People can review without having commit privs, though.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2006-02-15 01:42:47 Re: Patch Submission Guidelines
Previous Message Simon Riggs 2006-02-14 22:54:13 Re: Patch Submission Guidelines

Browse pgsql-patches by date

  From Date Subject
Next Message Robert Treat 2006-02-15 01:42:47 Re: Patch Submission Guidelines
Previous Message Simon Riggs 2006-02-14 22:54:13 Re: Patch Submission Guidelines