Re: tiny fix needed

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: tiny fix needed
Date: 2006-11-27 08:41:22
Message-ID: 3182.24.211.165.134.1164616882.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> "Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
>> I have just discovered a tiny fix that is needed when compiling on
>> Windows
>> with a very late model libintl.h. Essentially we need to add vfprintf to
>> the list of items we stop the libintl headers from hijacking. I am still
>> testing, but this change (3 extra lines in port.h) should be very low
>> risk.
>
> Hm, you mean only
>
> #ifdef vfprintf
> #undef vfprintf
> #endif
>
> This seems a bit strange, because the other functions such as vsnprintf
> have several other relevant bits in port.h, plus supporting code in
> src/port/ ... why wouldn't we need all of that?
>

*sigh* you could well be right. I will dig some more. It only happens for
ECPG - everything else links just fine.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2006-11-27 08:51:03 Re: [CORE] RC1 blocker issues
Previous Message Jeroen T. Vermeulen 2006-11-27 08:12:50 Re: "Optional ident" authentication