Re: tiny fix needed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: tiny fix needed
Date: 2006-11-27 03:29:46
Message-ID: 1944.1164598186@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
> I have just discovered a tiny fix that is needed when compiling on Windows
> with a very late model libintl.h. Essentially we need to add vfprintf to
> the list of items we stop the libintl headers from hijacking. I am still
> testing, but this change (3 extra lines in port.h) should be very low
> risk.

Hm, you mean only

#ifdef vfprintf
#undef vfprintf
#endif

This seems a bit strange, because the other functions such as vsnprintf
have several other relevant bits in port.h, plus supporting code in
src/port/ ... why wouldn't we need all of that?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-11-27 03:55:58 Re: [PATCHES] Avg performance for int8/numeric
Previous Message Andrew Dunstan 2006-11-27 03:10:34 tiny fix needed