I wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> This broke the buildfarm on Windows, and I'm not sure of the best way to fix it.
> Hm, those symbols are already in use elsewhere in the code; I would
> assume it's just a matter of missing #includes in these particular
> files. Where does Windows define 'em?
Ah, I have a theory: <fcntl.h>. Seems that ancient Unix specs say
S_IRUSR etc should be defined there, rather than <sys/stat.h> which
is the modern expectation. Count on M$ to find creative ways of being
incompatible ...
regards, tom lane
In response to
Responses
pgsql-hackers by date
| Next: | From: Magnus Hagander | Date: 2010-12-11 16:18:51 |
| Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal
constants for file permission flags |
| Previous: | From: Tom Lane | Date: 2010-12-11 15:56:19 |
| Subject: Re: create tablespace fails silently, or succeeds improperly |
pgsql-committers by date
| Next: | From: Magnus Hagander | Date: 2010-12-11 16:18:51 |
| Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal
constants for file permission flags |
| Previous: | From: Tom Lane | Date: 2010-12-11 15:27:07 |
| Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |