| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| Date: | 2010-12-11 15:27:07 |
| Message-ID: | 2415.1292081227@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> This broke the buildfarm on Windows, and I'm not sure of the best way to fix it.
> We currently define read and write permissions in port/win32.h
> specifically for windows. A quick-fix to just add these new ones as
> aliases won't work, because they are used in both open and umask
> calls.
Hm, those symbols are already in use elsewhere in the code; I would
assume it's just a matter of missing #includes in these particular
files. Where does Windows define 'em?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-11 16:13:12 | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| Previous Message | Robert Haas | 2010-12-11 14:36:25 | pgsql: Allow bidirectional copy messages in streaming replication mode. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitriy Igrishin | 2010-12-11 15:28:20 | Re: proposal: auxiliary functions for record type |
| Previous Message | Florian Pflug | 2010-12-11 15:24:41 | Re: proposal: auxiliary functions for record type |