| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP) |
| Date: | 2010-08-10 17:35:30 |
| Message-ID: | 3015.1281461730@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Joseph Adams's message of mar ago 10 04:03:43 -0400 2010:
>> An overview, along with my thoughts, of the utility functions:
>>
>> FN_EXTRA, FN_EXTRA_ALLOC, FN_MCXT macros
>> * Useful-ometer: ()--------------------o
>>
>> TypeInfo structure and getTypeInfo function
>> * Useful-ometer: ()---------------------------o
>>
>> getEnumLabelOids
>> * Useful-ometer: ()-----------------------------------o
> I think this kind of thing could be stripped from the patch and
> submitted separately;
+1. It's easier all around if a patch does just one thing. Code
refactoring and feature addition, in particular, are easier to review
separately.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-08-10 17:40:46 | Re: Libpq: PQftype, PQfsize |
| Previous Message | Tom Lane | 2010-08-10 17:22:04 | Re: Session timeout on commitfest.postgresql.org |