Re: Text search segmentation fault

From: Grzegorz Jaśkiewicz <gryzman(at)gmail(dot)com>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Tommy Gildseth <tommy(dot)gildseth(at)usit(dot)uio(dot)no>, General Postgres Mailing List <pgsql-general(at)postgresql(dot)org>
Subject: Re: Text search segmentation fault
Date: 2009-01-29 16:15:45
Message-ID: 2f4958ff0901290815o1e4b7527ie23336b10e6e123a@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Thu, Jan 29, 2009 at 4:06 PM, Gregory Stark <stark(at)enterprisedb(dot)com> wrote:
> Gregory Stark <stark(at)enterprisedb(dot)com> writes:

> Ah, I understand how this fixes the problem. You were casting to unsigned
> *int* not unsigned char so it was sign extending first and then overflowing.
:)

> It still seems to me if you put a few "unsigned" in variable declarations you
> could remove piles upon piles of casts and make all of the code more readable.

which is one of the main problems I see with that code, overall.

--
GJ

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2009-01-29 16:27:10 Re: Text search segmentation fault
Previous Message Daniel Chiaramello 2009-01-29 16:14:02 Re: chinese parser for text search !