Re: visibility maps

From: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: visibility maps
Date: 2008-12-05 07:25:17
Message-ID: 2e78013d0812042325y72ac4f0eg27718a0b673c8ef4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

/*
* Size of the bitmap on each visibility map page, in bytes. There's no
* extra headers, so the whole page minus except for the standard page
header
* is used for the bitmap.
*/
#define MAPSIZE (BLCKSZ - SizeOfPageHeaderData)

ISTM that we should MAXALIGN the SizeOfPageHeaderData to compute MAPSIZE.
PageGetContents() works that way and I believe that's the right thing to do.

Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2008-12-05 07:47:30 Re: In-place upgrade: catalog side
Previous Message Pavan Deolasee 2008-12-05 07:10:10 visibility maps