| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16346: pg_upgrade fails on a trigger with a comment |
| Date: | 2020-04-08 15:34:17 |
| Message-ID: | 29776.1586360057@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> writes:
> To recap, the attached patch moves restoration of comments to the
> RESTORE_PASS_POST_ACL. This ensures that comments are
> restored in a PASS when essentially all required objects are created
> including event triggers and materialized views (and any other db
> objects).
This is surely not a good idea as it stands, because it delays restore
of *all* object comments to the very end. That's not nice for parallel
restores, and it also has large impact on pg_dump's behavior in cases
that have nothing to do with event triggers; which could cause unforeseen
problems.
The right way is to postpone only event trigger comments. I fixed it
that way and pushed it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2020-04-08 15:58:57 | BUG #16352: Data corruption in few tables |
| Previous Message | Johannes Mols | 2020-04-08 14:58:04 | Re: BUG #16351: PostgreSQL closing connection during requests with segmentation fault |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-08 15:40:59 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | David Steele | 2020-04-08 15:29:25 | Re: [PATCH] Incremental sort |