Skip site navigation (1) Skip section navigation (2)

Re: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Date: 2013-01-09 19:07:58
Message-ID: 29246.1357758478@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-01-09 11:27:46 -0500, Tom Lane wrote:
>> I'd prefer posting a single message with the discussion and the
>> patch(es).  If you think it's helpful to split a patch into separate
>> parts for reviewing, add multiple attachments.  But my experience is
>> that such separation isn't nearly as useful as you seem to think.

> Well, would it have been better if xlog reading, ilist, binaryheap, this
> cleanup, etc. have been in the same patch? They have originated out of
> the same work...
> Even the splitup in this thread seems to have helped as youve jumped on
> the patches where you could give rather quick input (static
> relpathbackend(), central Assert definitions), probably without having
> read the xlogreader patch itself...

No, I agree that global-impact things like this palloc rearrangement are
much better proposed and debated separately than as part of something
like xlogreader.  What I was reacting to was the specific patch set
associated with this thread.  I don't see the point of breaking out a
two-line sub-patch such as you did in
http://archives.postgresql.org/message-id/1357730830-25999-3-git-send-email-andres@2ndquadrant.com

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Jan UrbaƄskiDate: 2013-01-09 19:08:39
Subject: Re: [PATCH] PL/Python: Add spidata to all spiexceptions
Previous:From: Josh BerkusDate: 2013-01-09 18:58:21
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group