Re: column name is "LIMIT"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Gourish Singbal <gourish(at)gmail(dot)com>, Russell Smith <mr-russ(at)pws(dot)com(dot)au>, pgsql-performance(at)postgresql(dot)org
Subject: Re: column name is "LIMIT"
Date: 2005-03-14 19:30:39
Message-ID: 29101.1110828639@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-performance

Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> quote_ident() function doesn't quote reserved words ... as it IMHO is
> supposed to do.

You're right, it probably should. The equivalent code in pg_dump knows
about this, but quote_ident() doesn't.

One thing that's been on my mind with respect to all this is that it
would be nice not to quote "non-reserved" keywords. Most of the weird
non-SQL-spec keywords that we have are non-reserved, and we could more
easily keep them out of people's faces if we didn't quote them in dumps.
Of course such a policy would raise the ante for any change that makes
an existing keyword reserved when it wasn't before, but that's already
a dangerous kind of change.

regards, tom lane

In response to

Browse pgsql-performance by date

  From Date Subject
Next Message Miroslav Šulc 2005-03-14 19:31:51 Re: Avoiding tuple construction/deconstruction during joining
Previous Message Bryan Encina 2005-03-14 19:26:44 Re: column name is "LIMIT"