Re: Building PostgreSQL 9.6devel sources with Microsoft Visual C++ 2015?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
Cc: pgsql-general(at)postgresql(dot)org
Subject: Re: Building PostgreSQL 9.6devel sources with Microsoft Visual C++ 2015?
Date: 2016-01-21 21:42:44
Message-ID: 29010.1453412564@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru> writes:
> +#if _MSC_VER >= 1800
> + //From VS2012.
> + typedef struct localerefcount
> + {
> + char *locale;
> + wchar_t *wlocale;
> + ... etc etc ...

Ick. Even if that works today, it seems absolutely guaranteed to fail
in future, as soon as Microsoft either puts back the visible declaration
or changes the struct contents. If they've made a conscious decision
to not export the struct anymore, it's likely because they intend to
change it ... so I'd put the half-life of this "fix" at no more than one
Visual Studio release.

Hopefully, if they removed the visible declaration intentionally, they
provided some other way to get at those locale names. That's what we
need to be looking for, not hoping that direct access to undocumented
structures will continue to work.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Johannes 2016-01-21 21:59:18 Re: long transfer time for binary data
Previous Message Steve Litt 2016-01-21 20:40:25 Re: CoC [Final]