Re: BUG #2056: to_char no long takes time as input?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Nick Addington" <adding(at)math(dot)wisc(dot)edu>
Cc: pgsql-bugs(at)postgresql(dot)org, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: BUG #2056: to_char no long takes time as input?
Date: 2005-11-20 16:59:47
Message-ID: 28941.1132505987@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

"Nick Addington" <adding(at)math(dot)wisc(dot)edu> writes:
> The following code works in 8.0.4 but fails in 8.1.0:
> select to_char('1:00 pm'::time,'HH:MM AM');

I'm inclined to think that disallowing AM/PM for intervals was a mistake
--- if we allow both HH and HH24 (which we do) then the various flavors
of AM/PM seem reasonable to allow as well.

Bruce, did you have a specific rationale for that?

I notice the code now specifically forces HH to be treated as HH24 in
the interval case, which was not so before 8.1; we would need to revert
that change as well to continue supporting TIME cases reasonably.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Mantelos Dimitrios 2005-11-20 21:19:10 BUG #2058: Wrong Greek ISO-encoding assignment
Previous Message Martin Pitt 2005-11-20 15:32:27 Fwd: Bug#338645: postgresql-contrib-8.1: dbf2pg silently ignores the -F and -T options

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-11-20 17:43:42 Re: Numeric 508 datatype
Previous Message Michael Fuhr 2005-11-20 09:07:14 Re: BUG #2056: to_char no long takes time as input?