Re: Alpha test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Alpha test
Date: 2003-12-23 00:25:33
Message-ID: 28821.1072139133@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> example, we have *no* evidence to suggest that that NOFIXADE stuff in
>> main.c is needed on platforms that don't define __alpha. I would tend
>> to take an "if it ain't broke don't fix it" approach, especially on
>> platforms we don't have handy to test.

> The problem was that certain cases tested for __alpha__ and some
> __alpha --- same with __sparc.

My point is that without testing, you have no way to know that that
variation is not correct, and perhaps even necessary. Given that this
code has been through many releases already, I think the odds that you
are breaking something are higher than the odds that you are fixing
something. I think you should leave well enough alone until we get an
actual bug report showing that there's a problem.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-12-23 00:31:52 remove NEED_I386_TAS_ASM
Previous Message Bruce Momjian 2003-12-23 00:22:29 Re: Alpha test