Re: Adding an ignore list to pg_restore

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pitt <mpitt(at)debian(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: Adding an ignore list to pg_restore
Date: 2006-02-18 19:34:39
Message-ID: 28645.1140291279@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Martin Pitt <mpitt(at)debian(dot)org> writes:
> Tom Lane [2006-02-18 13:32 -0500]:
>> Martin Pitt <mpitt(at)debian(dot)org> writes:
>>> The core problem is that we want to not restore objects (mainly
>>> tables) in the destination database which already exist.
>>
>> Why is this a problem? It's already the default behavior --- the
>> creation commands fail but pg_restore keeps going.

> The problem is that pg_restore would restore the TABLE DATA object,
> although we don't want that (the postgis specific tables are
> pre-populated by PostGIS itself, and should not be altered by the
> upgrade.

Hm. Rather than a variant of the -L facility (which is hard to use,
and I don't see your proposal being much easier), maybe what's wanted
is just a flag saying "don't try to restore data into any table whose
creation command fails". Maybe that should even be the default ...
and you could extend it to indexes and constraints on such tables too,
as those would likely end up being duplicated as well.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-02-18 19:37:44 Re: Config file for psql
Previous Message Michael Fuhr 2006-02-18 19:19:39 Re: Config file for psql